Birmingham | 26-ITP-May | Tobias Amaechina | Sprint 3 | Sprint-3/todo-list - #1327
Open
Tobias-Amaechina wants to merge 16 commits into
Open
Birmingham | 26-ITP-May | Tobias Amaechina | Sprint 3 | Sprint-3/todo-list#1327Tobias-Amaechina wants to merge 16 commits into
Tobias-Amaechina wants to merge 16 commits into
Conversation
…s completed task
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cjyuan
reviewed
Aug 1, 2026
Comment on lines
+17
to
+20
| <input type="text" id="new-task-input" placeholder="Enter a new task..." /> | ||
| <input type="date" id="new-task-deadline" /> | ||
| <button id="add-task-btn">Add</button> | ||
| </div> |
| // Replace the old array contents | ||
| todos.length = 0; | ||
| todos.push(...newTodos); | ||
|
|
Contributor
There was a problem hiding this comment.
Why not perform the operations on lines 45-46 in Todos.deleteCompleted()?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I updated the ( Sprint-3/todo-list/index.html, script.mjs, todos.mjs, todos.test.mjs, package.json.
Main feature additions:
Tasks now have an optional deadline (data model: todos include a deadline field).
UI: a date input for new tasks and a deadline display per item showing "Due today", "X days left", or "Overdue by X days".
New “Delete completed tasks” button and handler.
New Todos.deleteCompleted(todos) function and a unit test for it.
Sample data updated to include a deadline for one sample task.
package.json: bumped jest from ^30.0.4 to ^30.4.2.
Tests: added a unit test "deleteCompleted removes all completed tasks".
wrote a test to pass the deadline feature